TEM-131: riot parallelism #20

Merged

kalou merged 1 commit from refs/pull/20/head into engine/riot

2019-02-18 22:54:55 +00:00

kalou commented

2019-02-18 06:11:25 +00:00

(Migrated from git.kalou.net)

Riot seems super concurrency-unsafe, despite the library's claims to the contrary. Been poking around for a while but I'm pretty certain that it's because Riot's search functionality is not thread-safe, since it writes to a global map for some reason

https://github.com/go-ego/riot/issues/82

This PR is for merging into #19

kalou (Migrated from git.kalou.net) reviewed

2019-02-18 06:11:25 +00:00

kalou commented

2019-02-18 22:49:17 +00:00

(Migrated from git.kalou.net)

Codecov Report

❗ No coverage uploaded for pull request base (engine/riot@3560b71). Click here to learn what that means.
The diff coverage is 94.73%.

@@              Coverage Diff               @@
##             engine/riot      #20   +/-   ##
==============================================
  Coverage               ?   60.99%           
==============================================
  Files                  ?       18           
  Lines                  ?     1110           
  Branches               ?        0           
==============================================
  Hits                   ?      677           
  Misses                 ?      364           
  Partials               ?       69

Impacted Files	Coverage Δ
v2.go	`90.16% <100%> (ø)`
engine/engine.go	`96.74% <94.44%> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3560b71...00268cb. Read the comment docs.

# [Codecov](https://codecov.io/gh/RTradeLtd/Lens/pull/20?src=pr&el=h1) Report > :exclamation: No coverage uploaded for pull request base (`engine/riot@3560b71`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference#section-missing-base-commit). > The diff coverage is `94.73%`. [![Impacted file tree graph](https://codecov.io/gh/RTradeLtd/Lens/pull/20/graphs/tree.svg?width=650&token=nQgFgGoU0R&height=150&src=pr)](https://codecov.io/gh/RTradeLtd/Lens/pull/20?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## engine/riot #20 +/- ## ============================================== Coverage ? 60.99% ============================================== Files ? 18 Lines ? 1110 Branches ? 0 ============================================== Hits ? 677 Misses ? 364 Partials ? 69 ``` | [Impacted Files](https://codecov.io/gh/RTradeLtd/Lens/pull/20?src=pr&el=tree) | Coverage Δ | | |---|---|---| | [v2.go](https://codecov.io/gh/RTradeLtd/Lens/pull/20/diff?src=pr&el=tree#diff-djIuZ28=) | `90.16% <100%> (ø)` | | | [engine/engine.go](https://codecov.io/gh/RTradeLtd/Lens/pull/20/diff?src=pr&el=tree#diff-ZW5naW5lL2VuZ2luZS5nbw==) | `96.74% <94.44%> (ø)` | | ------ [Continue to review full report at Codecov](https://codecov.io/gh/RTradeLtd/Lens/pull/20?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/RTradeLtd/Lens/pull/20?src=pr&el=footer). Last update [3560b71...00268cb](https://codecov.io/gh/RTradeLtd/Lens/pull/20?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).