cleanup #10

Merged

kalou merged 0 commits from refs/pull/10/head into master

2018-11-23 20:27:59 +00:00

kalou commented

2018-11-23 08:51:05 +00:00

(Migrated from git.kalou.net)

while working on tesseract integrations, found some more room for improvement:

removed a lot of redundant comments
improved var naming
streamlined code
improved edge case handling to avoid panic, removed a stray log.Fatal
removed all prints

while working on tesseract integrations, found some more room for improvement: - removed a lot of redundant comments - improved var naming - streamlined code - improved edge case handling to avoid panic, removed a stray log.Fatal - removed all prints

kalou commented

2018-11-23 08:54:11 +00:00

(Migrated from git.kalou.net)

Codecov Report

❗ No coverage uploaded for pull request base (master@dec1497). Click here to learn what that means.
The diff coverage is 12.19%.

@@            Coverage Diff            @@
##             master      #10   +/-   ##
=========================================
  Coverage          ?   31.54%           
=========================================
  Files             ?        8           
  Lines             ?      577           
  Branches          ?        0           
=========================================
  Hits              ?      182           
  Misses            ?      360           
  Partials          ?       35

Impacted Files	Coverage Δ
lens.go	`0% <0%> (ø)`
search/search.go	`33.7% <20.83%> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dec1497...91f0145. Read the comment docs.

# [Codecov](https://codecov.io/gh/RTradeLtd/Lens/pull/10?src=pr&el=h1) Report > :exclamation: No coverage uploaded for pull request base (`master@dec1497`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference#section-missing-base-commit). > The diff coverage is `12.19%`. [![Impacted file tree graph](https://codecov.io/gh/RTradeLtd/Lens/pull/10/graphs/tree.svg?width=650&token=nQgFgGoU0R&height=150&src=pr)](https://codecov.io/gh/RTradeLtd/Lens/pull/10?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## master #10 +/- ## ========================================= Coverage ? 31.54% ========================================= Files ? 8 Lines ? 577 Branches ? 0 ========================================= Hits ? 182 Misses ? 360 Partials ? 35 ``` | [Impacted Files](https://codecov.io/gh/RTradeLtd/Lens/pull/10?src=pr&el=tree) | Coverage Δ | | |---|---|---| | [lens.go](https://codecov.io/gh/RTradeLtd/Lens/pull/10/diff?src=pr&el=tree#diff-bGVucy5nbw==) | `0% <0%> (ø)` | | | [search/search.go](https://codecov.io/gh/RTradeLtd/Lens/pull/10/diff?src=pr&el=tree#diff-c2VhcmNoL3NlYXJjaC5nbw==) | `33.7% <20.83%> (ø)` | | ------ [Continue to review full report at Codecov](https://codecov.io/gh/RTradeLtd/Lens/pull/10?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/RTradeLtd/Lens/pull/10?src=pr&el=footer). Last update [dec1497...91f0145](https://codecov.io/gh/RTradeLtd/Lens/pull/10?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).

kalou (Migrated from git.kalou.net) reviewed

2018-11-23 20:25:32 +00:00

kalou (Migrated from git.kalou.net) approved these changes

2018-11-23 20:27:46 +00:00

kalou (Migrated from git.kalou.net) left a comment

Amazing 💯

Amazing :100: