TEM-151: support for reindexing #14

Merged

kalou merged 0 commits from refs/pull/14/head into master 2018-12-11 21:23:43 +00:00

Conversation 4 Commits - Files changed -

kalou commented 2018-12-04 22:00:14 +00:00 (Migrated from git.kalou.net)

Copy link

• adds support for reindexing in API via https://github.com/RTradeLtd/grpc/pull/9 (specifically https://github.com/RTradeLtd/grpc/pull/9/files#diff-a273fc40d35e6ceedd0c13e8c4d3ba05R12)
• update behaviour of Store and related endpoints to accomodate Update behaviour
• minor fixes:
  • refactoring for interfaces, cleanliness
  • tests for a few functions (notably Lens.Service::Update and Server.API::Index)
  • added logging to gRPC middleware

- adds support for reindexing in API via https://github.com/RTradeLtd/grpc/pull/9 (specifically https://github.com/RTradeLtd/grpc/pull/9/files#diff-a273fc40d35e6ceedd0c13e8c4d3ba05R12) - update behaviour of `Store` and related endpoints to accomodate `Update` behaviour - minor fixes: - refactoring for interfaces, cleanliness - tests for a few functions (notably `Lens.Service::Update` and `Server.API::Index`) - added logging to gRPC middleware

kalou commented 2018-12-04 22:03:53 +00:00 (Migrated from git.kalou.net)

Copy link

Codecov Report

Merging #14 into master will increase coverage by 7.59%.
The diff coverage is 54.08%.

@@            Coverage Diff             @@
##           master      #14      +/-   ##
==========================================
+ Coverage   42.53%   50.13%   +7.59%     
==========================================
  Files          11       12       +1     
  Lines         710      750      +40     
==========================================
+ Hits          302      376      +74     
+ Misses        355      308      -47     
- Partials       53       66      +13

Impacted Files	Coverage Δ
search/search.go	32.96% <ø> (+2.23%)	⬆️
lens.go	53.73% <28%> (+12.68%)	⬆️
server/server.go	23.71% <41.02%> (+23.71%)	⬆️
server/opts.go	88.23% <88.23%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0cc3036...dcf5863. Read the comment docs.

# [Codecov](https://codecov.io/gh/RTradeLtd/Lens/pull/14?src=pr&el=h1) Report > Merging [#14](https://codecov.io/gh/RTradeLtd/Lens/pull/14?src=pr&el=desc) into [master](https://codecov.io/gh/RTradeLtd/Lens/commit/0cc30360a23d605c779365a62c3aafa9d0dd0063?src=pr&el=desc) will **increase** coverage by `7.59%`. > The diff coverage is `54.08%`. [](https://codecov.io/gh/RTradeLtd/Lens/pull/14?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## master #14 +/- ## ========================================== + Coverage 42.53% 50.13% +7.59% ========================================== Files 11 12 +1 Lines 710 750 +40 ========================================== + Hits 302 376 +74 + Misses 355 308 -47 - Partials 53 66 +13 ``` | [Impacted Files](https://codecov.io/gh/RTradeLtd/Lens/pull/14?src=pr&el=tree) | Coverage Δ | | |---|---|---| | [search/search.go](https://codecov.io/gh/RTradeLtd/Lens/pull/14/diff?src=pr&el=tree#diff-c2VhcmNoL3NlYXJjaC5nbw==) | `32.96% <ø> (+2.23%)` | :arrow_up: | | [lens.go](https://codecov.io/gh/RTradeLtd/Lens/pull/14/diff?src=pr&el=tree#diff-bGVucy5nbw==) | `53.73% <28%> (+12.68%)` | :arrow_up: | | [server/server.go](https://codecov.io/gh/RTradeLtd/Lens/pull/14/diff?src=pr&el=tree#diff-c2VydmVyL3NlcnZlci5nbw==) | `23.71% <41.02%> (+23.71%)` | :arrow_up: | | [server/opts.go](https://codecov.io/gh/RTradeLtd/Lens/pull/14/diff?src=pr&el=tree#diff-c2VydmVyL29wdHMuZ28=) | `88.23% <88.23%> (ø)` | | ------ [Continue to review full report at Codecov](https://codecov.io/gh/RTradeLtd/Lens/pull/14?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/RTradeLtd/Lens/pull/14?src=pr&el=footer). Last update [0cc3036...dcf5863](https://codecov.io/gh/RTradeLtd/Lens/pull/14?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).

kalou (Migrated from git.kalou.net) reviewed 2018-12-11 02:35:24 +00:00

kalou (Migrated from git.kalou.net) left a comment

Copy link

No description provided.

Looks good however we may want to add a few things 1) in `search/search.go` a `Close` function that can be used to terminate the connection to badgerds, and subsequently during the integration test add a `defer searcher.Close()` 2) Within `lens_test.go` should add a test which tests the reindexing of an object to make sure it doesn't fail and lets us reindex 3) In order to fix the integration test from hanging we can force a connection to our node which pins the hash causing a timeout. Perhaps in `make testenv` after the container is brought online we can add `ipfs --api=/ip4/127.0.0.1/tcp/5001 swarm connect /ip4/172.218.49.115/tcp/5002/ipfs/Qmf964tiE9JaxqntDsSBGasD4aaofPQtfYZyMSJJkRrVTQ`

kalou commented 2018-12-11 08:00:23 +00:00 (Migrated from git.kalou.net)

Copy link

Codecov Report

Merging #14 into master will increase coverage by 7.66%.
The diff coverage is 54.54%.

@@            Coverage Diff             @@
##           master      #14      +/-   ##
==========================================
+ Coverage   42.53%   50.19%   +7.66%     
==========================================
  Files          11       12       +1     
  Lines         710      751      +41     
==========================================
+ Hits          302      377      +75     
+ Misses        355      308      -47     
- Partials       53       66      +13

Impacted Files	Coverage Δ
search/search.go	33.33% <100%> (+2.6%)	⬆️
lens.go	53.73% <28%> (+12.68%)	⬆️
server/server.go	23.71% <41.02%> (+23.71%)	⬆️
server/opts.go	88.23% <88.23%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0cc3036...8aa7357. Read the comment docs.

# [Codecov](https://codecov.io/gh/RTradeLtd/Lens/pull/14?src=pr&el=h1) Report > Merging [#14](https://codecov.io/gh/RTradeLtd/Lens/pull/14?src=pr&el=desc) into [master](https://codecov.io/gh/RTradeLtd/Lens/commit/0cc30360a23d605c779365a62c3aafa9d0dd0063?src=pr&el=desc) will **increase** coverage by `7.66%`. > The diff coverage is `54.54%`. [](https://codecov.io/gh/RTradeLtd/Lens/pull/14?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## master #14 +/- ## ========================================== + Coverage 42.53% 50.19% +7.66% ========================================== Files 11 12 +1 Lines 710 751 +41 ========================================== + Hits 302 377 +75 + Misses 355 308 -47 - Partials 53 66 +13 ``` | [Impacted Files](https://codecov.io/gh/RTradeLtd/Lens/pull/14?src=pr&el=tree) | Coverage Δ | | |---|---|---| | [search/search.go](https://codecov.io/gh/RTradeLtd/Lens/pull/14/diff?src=pr&el=tree#diff-c2VhcmNoL3NlYXJjaC5nbw==) | `33.33% <100%> (+2.6%)` | :arrow_up: | | [lens.go](https://codecov.io/gh/RTradeLtd/Lens/pull/14/diff?src=pr&el=tree#diff-bGVucy5nbw==) | `53.73% <28%> (+12.68%)` | :arrow_up: | | [server/server.go](https://codecov.io/gh/RTradeLtd/Lens/pull/14/diff?src=pr&el=tree#diff-c2VydmVyL3NlcnZlci5nbw==) | `23.71% <41.02%> (+23.71%)` | :arrow_up: | | [server/opts.go](https://codecov.io/gh/RTradeLtd/Lens/pull/14/diff?src=pr&el=tree#diff-c2VydmVyL29wdHMuZ28=) | `88.23% <88.23%> (ø)` | | ------ [Continue to review full report at Codecov](https://codecov.io/gh/RTradeLtd/Lens/pull/14?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/RTradeLtd/Lens/pull/14?src=pr&el=footer). Last update [0cc3036...8aa7357](https://codecov.io/gh/RTradeLtd/Lens/pull/14?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).

kalou (Migrated from git.kalou.net) approved these changes 2018-12-11 21:09:48 +00:00

kalou (Migrated from git.kalou.net) left a comment

Copy link

🎉

:tada:

Sign in to join this conversation.

Reviewers

No reviewers

kalou

Labels

Clear labels   

bug

Something isn't working

  

duplicate

This issue or pull request already exists

  

enhancement

New feature or request

  

good first issue

Good for newcomers

  

help wanted

Extra attention is needed

  

invalid

This doesn't seem right

  

question

Further information is requested

  

status:review

  

status:wip

  

wontfix

This will not be worked on

No labels

bug

duplicate

enhancement

good first issue

help wanted

invalid

question

status:review

status:wip

wontfix

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

1 participant

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference

kalou/LensRT!14

No description provided.