analysis optimizations, code cleanup #9

Merged

kalou merged 0 commits from refs/pull/9/head into master

2018-11-21 22:22:40 +00:00

kalou commented

2018-11-21 08:09:08 +00:00

(Migrated from git.kalou.net)

at @postables 's recommendation, I started to look closer at the pdf library already in use. found some points for optimization, and did some cleanup, mostly in the primary lens package, and mostly to do with removing disk writes and using received bytes directly.

at @postables 's recommendation, I started to look closer at the pdf library already in use. found some points for optimization, and did some cleanup, mostly in the primary `lens` package, and mostly to do with removing disk writes and using received bytes directly.

kalou commented

2018-11-21 08:16:48 +00:00

(Migrated from git.kalou.net)

Codecov Report

Merging #9 into master will increase coverage by 0.71%.
The diff coverage is 16%.

@@            Coverage Diff             @@
##           master       #9      +/-   ##
==========================================
+ Coverage   29.53%   30.24%   +0.71%     
==========================================
  Files           8        8              
  Lines         623      605      -18     
==========================================
- Hits          184      183       -1     
+ Misses        408      392      -16     
+ Partials       31       30       -1

Impacted Files	Coverage Δ
lens.go	`0% <0%> (ø)`	⬆️
analyzer/images/tensorflow.go	`55% <100%> (+0.45%)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a567c05...9eeaeb4. Read the comment docs.

# [Codecov](https://codecov.io/gh/RTradeLtd/Lens/pull/9?src=pr&el=h1) Report > Merging [#9](https://codecov.io/gh/RTradeLtd/Lens/pull/9?src=pr&el=desc) into [master](https://codecov.io/gh/RTradeLtd/Lens/commit/a567c05a11ad01975dc351ac1ea79faa5f9719c0?src=pr&el=desc) will **increase** coverage by `0.71%`. > The diff coverage is `16%`. [![Impacted file tree graph](https://codecov.io/gh/RTradeLtd/Lens/pull/9/graphs/tree.svg?width=650&token=nQgFgGoU0R&height=150&src=pr)](https://codecov.io/gh/RTradeLtd/Lens/pull/9?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## master #9 +/- ## ========================================== + Coverage 29.53% 30.24% +0.71% ========================================== Files 8 8 Lines 623 605 -18 ========================================== - Hits 184 183 -1 + Misses 408 392 -16 + Partials 31 30 -1 ``` | [Impacted Files](https://codecov.io/gh/RTradeLtd/Lens/pull/9?src=pr&el=tree) | Coverage Δ | | |---|---|---| | [lens.go](https://codecov.io/gh/RTradeLtd/Lens/pull/9/diff?src=pr&el=tree#diff-bGVucy5nbw==) | `0% <0%> (ø)` | :arrow_up: | | [analyzer/images/tensorflow.go](https://codecov.io/gh/RTradeLtd/Lens/pull/9/diff?src=pr&el=tree#diff-YW5hbHl6ZXIvaW1hZ2VzL3RlbnNvcmZsb3cuZ28=) | `55% <100%> (+0.45%)` | :arrow_up: | ------ [Continue to review full report at Codecov](https://codecov.io/gh/RTradeLtd/Lens/pull/9?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/RTradeLtd/Lens/pull/9?src=pr&el=footer). Last update [a567c05...9eeaeb4](https://codecov.io/gh/RTradeLtd/Lens/pull/9?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).

kalou (Migrated from git.kalou.net) reviewed

2018-11-21 20:32:49 +00:00

kalou (Migrated from git.kalou.net) approved these changes

2018-11-21 20:33:40 +00:00

kalou (Migrated from git.kalou.net) left a comment

Very slick